-
Notifications
You must be signed in to change notification settings - Fork 138
fix: Update maxItems and maxTotalChargeUsd desc #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Preview for this PR was built for commit |
|
While you're at it, could you please also add |
stetizu1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably can't do anything about it now, but yes, it goes against our "unify pricing" initiative when we "name" the pricing models and then somehow hide it in the UI 😅
apify-api/openapi/paths/actor-tasks/actor-tasks@{actorTaskId}@run-sync-get-dataset-items.yaml
Outdated
Show resolved
Hide resolved
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
| - maxItems | ||
| - maxTotalChargeUsd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these actually required?
| results that will be charged to your subscription. You can access the | ||
| maximum number of items in your Actor by using the | ||
| `ACTOR_MAX_PAID_DATASET_ITEMS` environment variable. | ||
| Specifies the maximum number of dataset items that will be charged for pay-per-result Actors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see quite a bit of repetition here - could you make some reusable parameter objects and reference them in the relevant endpoints? See https://swagger.io/specification/#components-object
Note
Clarifies OpenAPI docs for
maxItems(pay-per-result charge cap) andmaxTotalChargeUsd(pay-per-event cost cap) across actor and task run endpoints, including env var references.maxItemsquery param description inactors/*run-sync*.yamlandactor-tasks/*run-sync*.yaml:ACTOR_MAX_PAID_DATASET_ITEMS.maxTotalChargeUsdquery param description inactors/*runs*.yaml,actors/*run-sync*.yaml, andactor-tasks/*runs*.yaml:ACTOR_MAX_TOTAL_CHARGE_USD.Written by Cursor Bugbot for commit 99fc4f1. Configure here.